Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hard lock dependency versions #298

Merged
merged 13 commits into from
Feb 28, 2025
Merged

fix: Hard lock dependency versions #298

merged 13 commits into from
Feb 28, 2025

Conversation

hudson-newey
Copy link
Member

@hudson-newey hudson-newey commented Feb 28, 2025

fix: Hard lock dependency versions

Some libraries do not follow semantic versioning, meaning that they allow for breaking changes in minor versions.

This can cause issues with our existing package.json which allows minor version bumps.

I have hard locked all dependencies.

Changes

  • Hard lock dependency versions in package.json
  • Install dependencies with --frozen-lock during CI
  • Upgrade dependencies

Related Issues

Fixes: #297

Final Checklist

  • All commits messages are semver compliant
  • Added relevant unit tests for new functionality
  • Updated existing unit tests to reflect changes
  • Code style is consistent with the project guidelines
  • Documentation is updated to reflect the changes (if applicable)
  • Link issues related to the PR
  • Assign labels if you have permission
  • Assign reviewers if you have permission
  • Ensure that CI is passing
  • Ensure that pnpm lint runs without any errors
  • Ensure that pnpm test runs without any errors

@hudson-newey hudson-newey self-assigned this Feb 28, 2025
@hudson-newey hudson-newey added bug Something isn't working CI cdn labels Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

@hudson-newey hudson-newey added the dependencies Pull requests that update a dependency file label Feb 28, 2025
@hudson-newey hudson-newey merged commit 8a886b4 into main Feb 28, 2025
6 checks passed
@hudson-newey hudson-newey deleted the version-locks branch February 28, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cdn CI dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production build has become disassociated with local builds
2 participants