Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Space to play with no grid selection should play all #287

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix: Space to play with no grid selection should play all #287

merged 2 commits into from
Feb 19, 2025

Conversation

hudson-newey
Copy link
Member

fix: Space to play with no grid selection should play all

Changes

  • Pressing space with no selection now makes all tiles in the verification grid play
  • The grid tile play event aborter is now in the verification grid (needed to check the grid size)
  • Fixes not being able to play a 1x1 verification grid tile with space

Related Issues

Fixes: #128
Fixes: #258

Final Checklist

  • All commits messages are semver compliant
  • Added relevant unit tests for new functionality
  • Updated existing unit tests to reflect changes
  • Code style is consistent with the project guidelines
  • Documentation is updated to reflect the changes (if applicable)
  • Link issues related to the PR
  • Assign labels if you have permission
  • Assign reviewers if you have permission
  • Ensure that CI is passing
  • Ensure that pnpm lint runs without any errors
  • Ensure that pnpm test runs without any errors

@hudson-newey hudson-newey self-assigned this Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

🚀 Deployed on https://67b650d9cb08e2c012624dbb--oe-web-components.netlify.app

atruskie
atruskie approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

Suggested comments to help my own brain understand.

Needs tests though.

@hudson-newey hudson-newey merged commit ae65ccc into main Feb 19, 2025
3 of 6 checks passed
@atruskie atruskie mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees

@hudson-newey hudson-newey

Labels
bug Something isn't working stakeholder-S stakeholder-SH triage: low ui
Projects
None yet
Milestone
No milestone
2 participants
@hudson-newey @atruskie