Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/helper
functions (these functions still have sub-optimal TS typing)HTMLAudioElement
(this allowsoe-media-controls
to access both elements through the same APIs and event bindings)playing
property topaused
playing
event toplay
I've done this to duck type the spectrogram component with
HTMLAudioElement
events, properties and attributes. This allowsoe-media-controls
to control spectrogram components andHTMLAudioElement
's through the same API's and eventsAdded tests
mount
tests that assert the correct events are emitted whenplay()
andpause()
are called<source>
element can be used as a media source in the spectrogram components default<slot>
oe-media-controls
can correctly mount/unmount and re-mount to spectrograms correctlyoe-media-controls
unit test example that is no longer needed (we originally created this as a proof of concept on how to test capturing events. Additionally,playing
state is now handled by theoe-spectrogram
component) this test is no longer needed as we have a practical example of testing captured events in theoe-spectrogram
component