feat(IntentSource): vault based intents #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/IntentSource.sol
Outdated
Comment on lines
62
to
64
| function intentVaultAddress( | ||
| Intent calldata intent | ||
| ) internal view returns (address) { |
There was a problem hiding this comment.
Can the intentVaultAddress function be a pure function since it's not reading any state or is it required to access calldata?
contracts/IntentSource.sol
Outdated
Comment on lines
176
to
189
| function withdrawRewards(Intent calldata intent) public { | ||
| bytes32 intentHash = keccak256(abi.encode(intent)); | ||
| address claimant = SimpleProver(intent.prover).provenIntents( | ||
| intentHash | ||
| ); | ||
|
|
||
| if (claimant != address(0) && !claimed[intentHash]) { | ||
| vaultClaimant = claimant; | ||
| claimed[intentHash] = true; | ||
|
|
||
| emit Withdrawal(intentHash, claimant); | ||
| } else { | ||
| if (block.timestamp < intent.expiryTime) { | ||
| revert UnauthorizedWithdrawal(intentHash); |
There was a problem hiding this comment.
Should we mark the intent as claimed when the intent has expired and the creator claims it back?
|
can this PR be against main rather than AUDIT? just dont want to mix those changes up order-wise |
# Conflicts: # contracts/Inbox.sol # contracts/IntentSource.sol # contracts/interfaces/IInbox.sol # contracts/interfaces/IIntentSource.sol # contracts/types/Intent.sol # yarn.lock
re1ro
force-pushed
the
feat/vault-based-intents
branch
from
559341f to
f01475e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntentSource: storage-less intents