Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Feature/hierarchical graphs #37

Merged
merged 26 commits into from
Dec 2, 2024

Conversation

icedoom888
Copy link
Contributor

An implementation of hierarchical graph model.
This allows for the creation of a model capable of dealing with multi-layered hierarchical graphs.
The model is agnostic to the choosen architecture (GNN, GraphTransformer).

@FussyDuck
Copy link

FussyDuck commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@mchantry
Copy link
Member

@icedoom888 thanks for the contribution.
Could you rebase it on top of
https://github.com/ecmwf/anemoi-models/pull/45/files which should be merged in the next day.
to solve the instantiate issue?

@icedoom888
Copy link
Contributor Author

Hello @mchantry, @floriankrb, I am currently blocked due to the switch to anemoi-training from aifs-mono.
Will resume working on this and address your comments once my pipeline is functional again!

@icedoom888
Copy link
Contributor Author

UPDATE:

  • Full refactor of hierarchical model implementation (done w/ @JPXKQX )
  • More readable code
  • Moving to anemoi-training for model testing

Please feel free to take a look and make any sort of suggestions!

This was referenced Nov 11, 2024
@JPXKQX JPXKQX requested a review from HCookie November 26, 2024 08:26
src/anemoi/models/models/hierarchical.py Outdated Show resolved Hide resolved
src/anemoi/models/models/hierarchical.py Show resolved Hide resolved
src/anemoi/models/models/hierarchical.py Outdated Show resolved Hide resolved
@icedoom888 icedoom888 self-assigned this Dec 2, 2024
@JPXKQX JPXKQX merged commit 2ff0807 into ecmwf:develop Dec 2, 2024
17 checks passed
@JPXKQX JPXKQX mentioned this pull request Dec 5, 2024
theissenhelen pushed a commit that referenced this pull request Dec 18, 2024
* Hard coded implementation of the hierarchical graph model

* Added implementation of Hierarchical Graph networks

* Added instantiate model in interface init

* if-else branching instead of hydra:instantiate, have to fix this in the future.

* Added changes before migration

* WORKING implementation of Hierarchical graph network

* Refactor and cleaning

* Added example config

* Minor refactor

* Refactor

* Refactor and rebase

* Refactor and small changes for merge

* Re-added asserts in mapper

* Added entry in changelog

* Refactor pre-merge

* Refactored the hierarchical model

* Test dimentions completed.

* Fixed dynamo issue

* Refactored using NamedNodesAttributes

* Fixed with git pre-commit

* Update src/anemoi/models/models/hierarchical.py

Co-authored-by: Mario Santa Cruz <[email protected]>

* Update src/anemoi/models/models/hierarchical.py

Co-authored-by: Mario Santa Cruz <[email protected]>

---------

Co-authored-by: Mario Santa Cruz <[email protected]>
theissenhelen pushed a commit that referenced this pull request Dec 19, 2024
* Hard coded implementation of the hierarchical graph model

* Added implementation of Hierarchical Graph networks

* Added instantiate model in interface init

* if-else branching instead of hydra:instantiate, have to fix this in the future.

* Added changes before migration

* WORKING implementation of Hierarchical graph network

* Refactor and cleaning

* Added example config

* Minor refactor

* Refactor

* Refactor and rebase

* Refactor and small changes for merge

* Re-added asserts in mapper

* Added entry in changelog

* Refactor pre-merge

* Refactored the hierarchical model

* Test dimentions completed.

* Fixed dynamo issue

* Refactored using NamedNodesAttributes

* Fixed with git pre-commit

* Update src/anemoi/models/models/hierarchical.py

Co-authored-by: Mario Santa Cruz <[email protected]>

* Update src/anemoi/models/models/hierarchical.py

Co-authored-by: Mario Santa Cruz <[email protected]>

---------

Co-authored-by: Mario Santa Cruz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants