Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test aicon in CI with pytest #76

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

feat: test aicon in CI with pytest #76

wants to merge 36 commits into from

Conversation

MeraX
Copy link
Contributor

@MeraX MeraX commented Jan 13, 2025 •
edited by HCookie
Loading

This bases on #75 and adds a short integration test to test the training of aicon.

Should be merged when the issues in #75 have been resolved.

@MeraX MeraX requested a review from JesperDramsch January 13, 2025 18:01
@FussyDuck
Copy link

FussyDuck commented Jan 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JesperDramsch JesperDramsch marked this pull request as draft January 15, 2025 14:00
@JesperDramsch
ci: move fail-fast up one
83aa204
@JesperDramsch
ci(pytest): get changes for three trigger scenarios
ad6dbc1
@JesperDramsch
ci(pytest): get more history
fed5eaf
@JesperDramsch
ci(pytest): consolidate pip install and fix pytest command
4f61c0d
@JesperDramsch
fix: autocorrect moment
e17ebb3
@JesperDramsch
ci: show chagned files
4fac0aa
@JesperDramsch
ci: use merge-base to get correct base commit
a53870c
@JesperDramsch
expand python test versions
77ec8db
@JesperDramsch
ci: timeouts and lenient grep
0c14de1
@JesperDramsch
ci: matrix for local-changes
19fc989
@JesperDramsch
ci: change scheduled run to "all"
04bac92
@JesperDramsch
ci(pytest): allow failures on with partial pypi installs
8696cec
@JesperDramsch
set timeout for job
96766d8
@JesperDramsch
ci: where does the timeout go?
2b26c31
@JesperDramsch
ci: make workflow triggerable
193cb6e
@JesperDramsch
ci: uv run
14ef60e
@JesperDramsch
ci(pytest): update conditionals
29e3c23
@JesperDramsch
fix: make matrix it a list
fae1a9c
@JesperDramsch
Implement proper skip and matrix platform
c90639c
@JesperDramsch
try from JSON solution
cb95ea6
@JesperDramsch
remove uv
6c61220
@JesperDramsch
ci(pytest): skip release tests label
36aa21b
@MeraX MeraX changed the title Draft: ci: test aicon in CI with pytest feat: test aicon in CI with pytest Jan 28, 2025
@MeraX
Copy link
Contributor Author

MeraX commented Jan 28, 2025

@JesperDramsch or @HCookie could you have a look at the install-mode? It somehow evaluated to "true", which is an invalid value. The error appears on this PR https://github.com/ecmwf/anemoi-core/actions/runs/13007212878 as well as on "main" https://github.com/ecmwf/anemoi-core/actions/runs/13008047920

When this issue is solved, I think this RP is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperDramsch JesperDramsch Awaiting requested review from JesperDramsch

At least 1 approving review is required to merge this pull request.

Assignees

@MeraX MeraX

Labels
training
Projects
Anemoi-dev
Status: Now In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeraX @FussyDuck @JesperDramsch