Skip to content

Conversation

@samhatfield
Copy link
Collaborator

This is precision agnostic so pretty straightforward to move to common. I just had to modify the signature so that NPROMA and NGPBLKS are passed as arguments. This is necessary because TPM_TRANS is not in common, so we cannot simply take these variables from that module.

Note that the GPU version could have been deleted in any case as it isn't used at all.

This is precision agnostic so pretty straightforward to move to common.
I just had to modify the signature so that NPROMA and NGPBLKS are passed
as arguments. This is necessary because TPM_TRANS is not in common, so
we cannot simply take these variables from that module.

Note that the GPU version could have been deleted in any case as it
isn't used at all.
@samhatfield samhatfield added enhancement New feature or request tidying Tidying up code or removing unused features easy review This one can be reviewed really quickly. labels Dec 5, 2025
@samhatfield samhatfield added this to the 1.8.0 milestone Dec 22, 2025
@wdeconinck
Copy link
Collaborator

I see the reason for doing this, but on the other hand, "common" is also intended to be common between cpu and gpu code paths.
As you found out, it is not shared with the gpu code path, so I am not entirely happy with the move to common as a code cleanup.
For the gpu code path, we also have a ectrans_gpu_common library for precision independent routines. For the cpu code path we did not do this. This would be the right approach here as well but I am not sure it is worth the extra complexity for one file currently?

@samhatfield
Copy link
Collaborator Author

That's fair enough. So would you say the common library is for stuff actually used by both CPU and GPU backends, not just stuff that can work regardless of the precision and the backend? In that case INIGPTR should not go in common.

We can still delete INIGPTR from the GPU backend.

@samhatfield samhatfield changed the title Move INIGPTR to common Delete unused gpu/INIGPTR subroutine Jan 6, 2026
@samhatfield
Copy link
Collaborator Author

PR updated so it just deletes the unused gpu/INIGPTR subroutine.

@wdeconinck wdeconinck merged commit aaaa0e4 into develop Jan 8, 2026
23 of 31 checks passed
@samhatfield samhatfield deleted the inigptr_common branch January 13, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy review This one can be reviewed really quickly. enhancement New feature or request tidying Tidying up code or removing unused features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants