-
Notifications
You must be signed in to change notification settings - Fork 47
[DRAFT] Remove redundant adjoint GPU communication routines #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
ee9a97f to
8e42ca4
Compare
b68ad6b to
8a58a58
Compare
268c21a to
f995241
Compare
|
Any thoughts on this @l90lpa? I was hoping I could also delete |
|
Hi @samhatfield, sorry for the slow reply. Yes, I had originally wanted to take the approach you're discussing, however, the issue I ran into was that |
In the CPU code path, we don't have "AD" versions for
TRLTOG,TRLTOMetc. Instead we simply use the inverse routine (e.g. G->L instead of L->G) with the input / output arguments swapped. In the GPU code path though we have additional subroutinesTRLTOMADandTRMTOLAD. This PR is for investigating whether these routines can be eliminated. If this succeeds, then we can close PR #340 unmerged.