Make sure MPI is found when GPU and MPI enabled #334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GPU version still has raw MPI calls so we must find MPI in the case when GPU and MPI features are enabled. Note that disabling MPI is done through FIAT's MPI feature.
Collaborator
Author
dhaumont
approved these changes
Nov 14, 2025
Collaborator
Author
|
Actually @dhaumont, @wdeconinck and I think we have a better solution which will pave the way towards eventually switching to pure MPL calls. This will bring the GPU version in line with the CPU version. Will try to draft another PR today. |
Contributor
|
I understand. But as the problem has been identified and we have a workaround, I would push this PR to fix the broken build, and prevent other people from wasting as much time as I did. |
Collaborator
Author
It's not a huge amount of coding required - I'm already testing the new branch now. |
Collaborator
Author
|
PR #335 is the preferred solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU version still has raw MPI calls so we must find MPI in the case when GPU and MPI features are enabled.
Note that disabling MPI is done through FIAT's MPI feature.