-
Notifications
You must be signed in to change notification settings - Fork 47
Factorize duplication between trltog and trgtol (cpu only) #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@samhatfield All your suggestions have been pushed. Looking forward to your PR into my branch |
- Lines can be up to 100 characters - Always two continuation characters - One indentation on the next line before the character
ECMWF suggestions for trltog_clean
|
Unfortunately it wasn't possible to collapse |
|
Overall I think this is a nice change and I like how the communication routines are much shorter and the complicated index calculations are done elsewhere. Now |
|
yes, it looks fine. |
Fix the bug that the size calculation for reallocation was incorrect due to the Z_HEAP buffer allocated with a lower bound of -1 see ecmwf-ifs#317 (comment)
|
I'll make one last check and then I think this is ready to merge. |
|
I realised after I started testing that there is still a bug in the checksum dumps for spectral fields. I'd like to test |
This PR is a refactoring to eliminate duplicated code between trltog and trgtol in the cpu branch.
The duplicated codehas been extracted into new routines in a new module trgl_mod, and they are called from trltog and trgtol.