refactor: remove check #5106
Open
refactor: remove check #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeikel
commented
Feb 7, 2024
| @@ -431,7 +431,7 @@ private HttpClientRequest createRequest( | |||
| if (!ABS_URI_START_PATTERN.matcher(u).find()) { | |||
| int defaultPort = 80; | |||
| String addPort = (authority.port() != -1 && authority.port() != defaultPort) ? (":" + authority.port()) : ""; | |||
| u = (useSSL == Boolean.TRUE ? "https://" : "http://") + authority.host() + addPort + requestURI; | |||
| u = "http://" + authority.host() + addPort + requestURI; | |||
There was a problem hiding this comment.
This check is not needed because in line 430, we're checking !useSSL
There was a problem hiding this comment.
@vietj Do you know what was the intention of this line?
yeikel
commented
Feb 7, 2024
| @@ -182,7 +182,7 @@ private EndpointProvider<EndpointKey, SharedClientHttpStreamEndpoint> httpEndpoi | |||
| ProxyOptions proxyOptions = key.proxyOptions; | |||
| if (proxyOptions != null && !key.ssl && proxyOptions.getType() == ProxyType.HTTP) { | |||
| SocketAddress server = SocketAddress.inetSocketAddress(proxyOptions.getPort(), proxyOptions.getHost()); | |||
| key = new EndpointKey(key.ssl, key.sslOptions, proxyOptions, server, key.authority); | |||
| key = new EndpointKey(false, key.sslOptions, proxyOptions, server, key.authority); | |||
There was a problem hiding this comment.
It is more explicit than key.ssl , and we are negating it in line 183
|
can you rebase on latest master there is a conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.