Support version for installExtension, support uninstall cmd

[dhuebner]

What it does

Allows to use version when executing workbench.extensions.installExtension command in format <extensionId>@<version> #13795
Adds support for workbench.extensions.uninstallExtension command #13796

How to test

Run uninstall on some installed extension. extension.uninstall now uses the new workbench.extensions.uninstallExtension under the hood.

Install command workbench.extensions.installExtension is currently not used in Theia with a string parameter, one need to create a separate command.

Follow-ups

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

I don't think this makes sense from a user's perspective: while technically, we can have multiple versions of the same plugin installed, that's not how it's presented to the user: for them, you either have a plugin installed, or not, independent of the version, so we should probably pass a naked id here.

[dhuebner]

PluginServer.uninstall() expects PluginIdentifiers.VersionedId parameter which is typed as ${string}.${string}@${string} that why it the code above makes sense to me.

that's not how it's presented to the user: for them, you either have a plugin installed, or not

The UNINSTALL_EXTENSION command is not presented to the user, but is used in theia/packages/vsx-registry/src/browser/vsx-extension.tsx where the versioned extension id is given.
I would prefer to keep require versioned id here.

[tsmaeder]

@dhuebner still some open questions on this one.

[dhuebner]

@tsmaeder
Yes, I need to go through and answer. Will do it this week.

[dhuebner]

@tsmaeder
Please find my answers above.
I removed the organize imports changes and added comments to the RegEx. Also re-based on current master.

[JonasHelming]

@tsmaeder Ping

[tsmaeder]

Hi Dennis, sorry for the delay, the last two releases have been somewhat crazy. Unfortunately, I still think this PR needs a bit of work.
Also, I don't really have a way to test the PR: when plugin API is involved and we don't have a known extension that exposes a plugin, we're making a little extension that exercises the API, in this case why not one that has two commands to install/uninstall with the user inputting a versioned id string?

[dhuebner]

@tsmaeder

Hi Dennis, sorry for the delay, the last two releases have been somewhat crazy.

No problem! Same here, a lot of TODOs :)

Unfortunately, I still think this PR needs a bit of work.

I've applied all the changes you suggested.

Also, I don't really have a way to test the PR: when plugin API is involved and we don't have a known extension that exposes a plugin, we're making a little extension that exercises the API, in this case why not one that has two commands to install/uninstall with the user inputting a versioned id string?

The simplest way to test is to add labels to the commands:

    export const INSTALL_FROM_VSIX: Command = {
        id: 'workbench.extensions.installExtension',
        label: nls.localizeByDefault('Install Extension')
    };

    export const UNINSTALL_EXTENSION: Command = {
        id: 'workbench.extensions.uninstallExtension',
        label: nls.localizeByDefault('Uninstall Extension')
    };

And then defaults for id parameters:

commands.registerCommand(VscodeCommands.INSTALL_FROM_VSIX, {
            execute: async (vsixUriOrExtensionId: TheiaURI | UriComponents | string = 'langium.langium-vscode') => {

commands.registerCommand(VscodeCommands.UNINSTALL_EXTENSION, {
            execute: async (id: string = '[email protected]') => {

Use Cmd+Shift+P to install and uninstall

[dhuebner]

Btw. "Install Extension" user command would be a nice feature for Theia. Like shown here in Installation section.