fix issue #3883: Remove redundant String.format usage#3884
Open
YianZhao wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
fix issue #3883: Remove redundant String.format usage#3884YianZhao wants to merge 1 commit intoeclipse-sw360:mainfrom
YianZhao wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
YianZhao
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
YianZhao
force-pushed
the
enhancement/cyclonedx-remove-nested-string-format
branch
from
6e980c4 to
4d9066b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3883
Summary
This PR removes a redundant nested
String.format(...)call inCycloneDxBOMImporter.Changes made
String.format(String.format(...))with a singleString.format(...)Why this change
The previous implementation worked, but it included unnecessary nesting that reduced readability. Since the inner
String.format(...)already produces the final string, the outer call was redundant.