feat(rest): add declaredLicense field to Release model#3880
Open
krrish175-byte wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
feat(rest): add declaredLicense field to Release model#3880krrish175-byte wants to merge 1 commit intoeclipse-sw360:mainfrom
krrish175-byte wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
Signed-off-by: krrish175-byte <[email protected]>
be3559b to
1fc26df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[[/]: # (This program and the accompanying materials are made)
[[/]: # (available under the terms of the Eclipse Public License 2.0)
[[/]: # (which is available at https://www.eclipse.org/legal/epl-2.0/)
[[/]: # (SPDX-License-Identifier: EPL-2.0)
Added a dedicated
declaredLicenseproperty to theReleaseThrift struct to natively separate SPDX license expressions from standard associated licenses. It handles seamless JSON serialization of the new field and ensures existing client workflows that use the"declared_license"key inadditionalDataare gracefully supported via backwards-compatible getters.This PR resolves #811 by providing a first-class property for genuine SPDX license expressions alongside
mainLicenseIdsandotherLicenseIds.No new dependencies were added.
Suggest Reviewer
@mcjaeger @AlbertHjy
How To Test?
Ensure the standard build command works locally with Thrift generation. Fetch a release through the REST API and verify that
declaredLicenseis successfully populated in the JSON payload if it is set.Yes, added testing and documentation of the
declaredLicensefield to API assertions inReleaseSpecTest.java.Checklist
Must: