fix(http-support): return null for missing native response headers#3879
Open
YianZhao wants to merge 2 commits intoeclipse-sw360:mainfrom
Open
fix(http-support): return null for missing native response headers#3879YianZhao wants to merge 2 commits intoeclipse-sw360:mainfrom
YianZhao wants to merge 2 commits intoeclipse-sw360:mainfrom
Conversation
Signed-off-by: Alex <[email protected]>
YianZhao
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3876
Description
The native HTTP response implementation does not follow the
Responseinterface contract for missing headers.Response.header(String name)documents that the method should returnnullif the requested header is not present. However,NewResponseImpl.header(String name)currently returns an empty string ("") instead.This PR fixes the implementation to return
nullfor missing headers.Result
The native implementation now matches the documented interface contract.