fix#3857 (http-support): implement native file request body support#3858
Open
YianZhao wants to merge 3 commits intoeclipse-sw360:mainfrom
Open
fix#3857 (http-support): implement native file request body support#3858YianZhao wants to merge 3 commits intoeclipse-sw360:mainfrom
YianZhao wants to merge 3 commits intoeclipse-sw360:mainfrom
Conversation
Signed-off-by: Alex <[email protected]>
YianZhao
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
Signed-off-by: YianZhao <[email protected]>
GMishx
added
needs code review
needs general test
Contributor
Author
|
Thanks for taking a look. All checks are passing on my side now. Please let me know if any changes are needed when you review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented native file body support in
NewRequestBodyBuilderImpl.file(Path, String).Bug: NewRequestBodyBuilderImpl.file() is unimplemented for native HTTP client #3857file(...)was previously unimplemented (TODO), so native client file upload body could not be created.BodyPublishers.ofFile(path)to create the request body.IOExceptionis wrapped inIllegalStateExceptionfor consistent builder error handling.Suggest Reviewer
@GMishx
How To Test?
Run: