fix #3855: (http-support): correct native request builder URI/body/header sem…#3856
Open
YianZhao wants to merge 3 commits intoeclipse-sw360:mainfrom
Open
fix #3855: (http-support): correct native request builder URI/body/header sem…#3856YianZhao wants to merge 3 commits intoeclipse-sw360:mainfrom
YianZhao wants to merge 3 commits intoeclipse-sw360:mainfrom
Conversation
…antics Signed-off-by: Alex <[email protected]>
Signed-off-by: YianZhao <[email protected]>
Contributor
Author
|
Thanks for taking a look. All checks are passing on my side now. Please let me know if any changes are needed when you review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes request-construction semantics in the native HTTP client path (
newHttpClientAlt) by updatingNewRequestBuilderImpl.What was wrong
NewRequestBuilderImplhad three behavior issues:Content-Type: application/jsonwas forced for all requests inbuild().These behaviors are inconsistent with expected HTTP request semantics and can produce incorrect requests.
Changes
Code changes
uri(String uri)to useURI.create(uri)directly, so invalid URIs fail fast withIllegalArgumentException.build()to useBodyPublishers.noBody()when no body is provided.Content-Type: application/jsoninjection frombuild().Tests added
Added new unit test class:
NewRequestBuilderImplTestCovered scenarios:
Content-Typeis preserved and not overridden.Verification
Executed: