Skip to content

feat(i18n): integrated japanese language in few pages #137

Open
Shrutim1505 wants to merge 3 commits intoeclipse-sw360:mainfrom
Shrutim1505:multilingual-support-japanese-lang
Open

feat(i18n): integrated japanese language in few pages #137
Shrutim1505 wants to merge 3 commits intoeclipse-sw360:mainfrom
Shrutim1505:multilingual-support-japanese-lang

Conversation

@Shrutim1505
Copy link
Contributor

Screenshot from 2025-04-02 13-53-11
Screenshot from 2025-04-02 13-52-19
Screenshot from 2025-04-02 14-01-56

GMishx and others added 3 commits March 30, 2025 15:51
Signed-off-by: Shruti78 <[email protected]>

feat(i18n): add multilingual support

Signed-off-by: Shruti78 <[email protected]>
@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Apr 2, 2025

@GMishx @KoukiHama @heliocastro
Could you please provide your suggestions/reviews on this?

@heliocastro
Copy link
Contributor

For sw360 frontend we're more relaxed, for documentation i'm not sure without a native proof reader. Afaik, only @KoukiHama is able to see it and is a lot.

@KoukiHama
Copy link
Member

Yes, I will review this one within few days.

@KoukiHama
Copy link
Member

I think it would be helpful to include a more detailed guide in the README for contributors who want to add new language translations. This would make it easier for others to get involved and ensure consistency across translations.

@Shrutim1505
Copy link
Contributor Author

Other than japanese, chinese ,french and vietnam?

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Apr 4, 2025

@KoukiHama
I was thinking of opening more pull request for supporting other languages.
Is that fine.?

And also I will update readme for updating other pages of website too.

Consider this pull request #137 as proposal.

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Apr 4, 2025

If there are any flaws correction, u could rectify me
@KoukiHama @GMishx

I have worked previously with this things in volcano.sh website, so.implemeted same things..
Any changes would be kept in mind

@KoukiHama
Copy link
Member

KoukiHama commented Apr 6, 2025

It will take some time to review regarding the Japanese language due to the large volume.

I will focus on reviewing the behavior and code in other areas about i18n(#123).

Also, please note that the timing of the merge may be delayed due to conflicts with other PRs because of the large impact.

@Shrutim1505
Copy link
Contributor Author

ok @KoukiHama .. thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants