-
Notifications
You must be signed in to change notification settings - Fork 146
JDT Clean-up Use String.replace() instead of String.replaceAll() when #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
possible In eclipse-platform/eclipse.platform.ui#3517 we discuss which automatic clean-ups we should add. This is the result of a manual run in eclipse-platform to see if this clean-up has issues. Also by running it manually before enabling the clean-ups we avoid creating PR per bundle.
|
Clean-up has issues eclipse-platform/eclipse.platform.ui#3544 |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
No this one is fine, thanks to verification from @merks |
|
Converrting to draft, as IMHO we should not apply such clean-ups shortly before a release. |
|
These changes also look fine to me. |
possible
In eclipse-platform/eclipse.platform.ui#3517 we discuss which automatic clean-ups we should add. This is the result of a manual run in eclipse-platform to see if this clean-up has issues. Also by running it manually before enabling the clean-ups we avoid creating PR per bundle.