Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 14, 2025

possible

In eclipse-platform/eclipse.platform.ui#3517 we discuss which automatic clean-ups we should add. This is the result of a manual run in eclipse-platform to see if this clean-up has issues. Also by running it manually before enabling the clean-ups we avoid creating PR per bundle.

possible

In eclipse-platform/eclipse.platform.ui#3517
we discuss which automatic clean-ups we should add. This is the result
of a manual run in eclipse-platform to see if this clean-up has
issues. Also by running it manually before enabling the clean-ups we
avoid creating PR per bundle.
@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

Clean-up has issues eclipse-platform/eclipse.platform.ui#3544

@vogella vogella closed this Nov 14, 2025
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Nov 14, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ua/org.eclipse.help.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f1dcf9c9d855923e40f6745aefdff73d9b4aeb8e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 14 Nov 2025 10:16:11 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
index 7593a41764..31c1079a58 100644
--- a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %help_system_plugin_name
 Bundle-SymbolicName: org.eclipse.help.ui; singleton:=true
-Bundle-Version: 4.8.200.qualifier
+Bundle-Version: 4.8.300.qualifier
 Bundle-Activator: org.eclipse.help.ui.internal.HelpUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@vogella vogella reopened this Nov 14, 2025
@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

Clean-up has issues eclipse-platform/eclipse.platform.ui#3544

No this one is fine, thanks to verification from @merks

@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

Converrting to draft, as IMHO we should not apply such clean-ups shortly before a release.

@vogella vogella marked this pull request as draft November 14, 2025 10:09
@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

These changes also look fine to me.

@github-actions
Copy link
Contributor

Test Results

 1 953 files  ±0   1 953 suites  ±0   1h 27m 57s ⏱️ + 3m 18s
 4 744 tests ±0   4 720 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 232 runs  ±0  14 050 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit 53af68d. ± Comparison against base commit b0bbf45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants