Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay attention to system.lineseparator in XML formatter tests #1712

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

akurtakov
Copy link
Member

Use the helper method to unify on the system line separator.

Use the helper method to unify on the system line separator.
@akurtakov
Copy link
Member Author

@jukzi Would you please that it fixes #1684 as I don't have access to windows?

@akurtakov akurtakov self-assigned this Jan 23, 2025
@jukzi
Copy link
Contributor

jukzi commented Jan 23, 2025

As i am not able to reproduce the issue locally i can not verify this will fix it. i'd say just merge to try - if verification builds succeeds. Meanwhile i wonder why the test did not fail in verification tests but only on i-build. Do the i-build use another git autcrlf setting then the verification builds?

@jukzi jukzi added regression Regression defect test junit test related things labels Jan 23, 2025
@akurtakov
Copy link
Member Author

That is a question which I can not answer.

Copy link
Contributor

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 35m 30s ⏱️ + 6m 47s
 4 170 tests ±0   4 147 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 940 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit cf09ede. ± Comparison against base commit 052dabe.

@akurtakov akurtakov merged commit bf02009 into eclipse-platform:master Jan 23, 2025
17 checks passed
@akurtakov
Copy link
Member Author

Merged, let's see next I-build results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression defect test junit test related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants