Fix traversal of CTabFolders with PgUp/PgDown #2864

[fedejeanne]

When traversing from an editor with tabs (e.g. a POM or MANIFEST editor), which is a CTabFolder itself, I made sure that the traversal happens from the top-level CTabFolder i.e. from the one that contains all open editors instead of trying to traverse inside the editor itself.

Fixes #2864

[github-actions]

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 17m 50s ⏱️ + 11m 6s
 8 234 tests ±0   7 984 ✅ ±0  249 💤 ±0  1 ❌ ±0 
23 622 runs  ±0  22 827 ✅ ±0  794 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 2aa86f6. ± Comparison against base commit 8b402ec.

♻️ This comment has been updated with latest results.

[BeckerWdf]

is this the same issue as reported / fixed in #3552 ?

[BeckerWdf]

@Christopher-Hermann

[Christopher-Hermann]

is this the same issue as reported / fixed in #3552 ?

Ah yes, damn. I did not see/find the initial issue.
It's definitely the same issue and even almost the same fix/code change we did :D

[Christopher-Hermann]

Looks good. Retested and everything works like expected.

[fedejeanne]

Thank you for looking into it, @Christopher-Hermann and @BeckerWdf ! If that's OK with you, I would like to merge my PR since I think getting the "top-level" CTabFolder is a bit safer than getting "the next CTabFolder (just a guess, not a hard-proven fact).

... but since you worked on it too ...

It's definitely the same issue and even almost the same fix/code change we did :D

... I added you both as Co-Authors :-)

I plan to merge as soon as 4.39 is open for development.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 1c0d12a633d19768fea03aa2f54c7e36b7dba87b Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 29 Nov 2025 07:27:40 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
index cb1c57314d..bf659aedc4 100644
--- a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true
-Bundle-Version: 3.137.0.qualifier
+Bundle-Version: 3.137.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.WorkbenchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

[fedejeanne]

Failing test is unrelated:

• Random failing org.eclipse.jface.text.tests.reconciler.FastAbstractReconcilerTest#testReplacingDocumentWhenClean() #2708