Fix incorrect SubMonitor usage patterns #3542
Draft
+18
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
claude/fix-submonitor-usage-01TksaDpbwkK6pUyfQabsKUt
branch
from
4a53ae5 to
4391a91
Compare
Contributor
vogella
force-pushed
the
claude/fix-submonitor-usage-01TksaDpbwkK6pUyfQabsKUt
branch
from
4391a91 to
326c667
Compare
This commit addresses SubMonitor anti-patterns as described in https://www.eclipse.org/articles/Article-Progress-Monitors/article.html Changes: 1. Removed unnecessary done() calls on monitors after SubMonitor.convert() - SubMonitor automatically handles done() when work is complete - Affected files: * Refactoring.java * PerformChangeOperation.java * PerformRefactoringOperation.java * MultiStateTextFileChange.java * TextChange.java * SmartImportJob.java (2 instances) * SaveablesList.java * SaveableHelper.java * CheckConditionsContext.java 2. Removed redundant isCanceled() checks after split() calls - split() already includes implicit cancellation checks - Affected files: * ProcessorBasedRefactoring.java (4 instances) * CheckConditionsContext.java * SaveablesList.java * SaveableHelper.java These changes improve code quality by following SubMonitor best practices and removing redundant code that could mask issues.
vogella
force-pushed
the
claude/fix-submonitor-usage-01TksaDpbwkK6pUyfQabsKUt
branch
from
326c667 to
cf4e18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses SubMonitor anti-patterns as described in https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
Changes:
Removed unnecessary done() calls on monitors after SubMonitor.convert()
Removed redundant isCanceled() checks after split() calls
These changes improve code quality by following SubMonitor best practices and removing redundant code that could mask issues.