Show ProgressMonitorJobsDialog after delay in ProgressManager.run #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 904 files ±0 2 904 suites ±0 2h 8m 46s ⏱️ + 8m 57s For more details on these failures, see this check. Results for commit 51bf991. ± Comparison against base commit 2f6a390. ♻️ This comment has been updated with latest results. |
Even for the backwards compatible mode (when the runnable is not forked or non-cancelable). This commit improves upon ccafe58 by letting the dialog pop up (after a delay) if the preferences "Always run in background" is set to false. When the preference is set to true, no progress dialog will ever pop up.
fedejeanne
force-pushed
the
show_progress_dialog_after_delay_if_should_not_run_in_background
branch
from
e2fa6de to
51bf991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3147 (comment)
Schedule the progress dialog to appear after a delay if the preference "Always run in background" is set to
false