Skip to content

Conversation

eclipse-platform-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

Copy link
Contributor

github-actions bot commented Sep 22, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 1m 33s ⏱️ + 5m 4s
 8 019 tests ±0   7 774 ✅ +1  245 💤 ±0  0 ❌  - 1 
23 591 runs  ±0  22 809 ✅ +1  782 💤 ±0  0 ❌  - 1 

Results for commit 98de65e. ± Comparison against base commit 8dc4f46.

♻️ This comment has been updated with latest results.


// Keyline = TITLE_BACKGROUND @ 50% Opacity over LIST_BACKGROUND
else if (testTwoPrimaryColors(tbBorder, 120, 180))
} else if (testTwoPrimaryColors(tbBorder, 120, 180)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjohnstn Another comment lost case, if you have time for it .

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.ui.forms branch from 1db919a to 98de65e Compare September 23, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants