Skip to content

Conversation

eclipse-platform-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

Copy link
Contributor

github-actions bot commented Sep 19, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 14m 23s ⏱️ + 20m 45s
 8 019 tests ±0   7 774 ✅ ±0  245 💤 ±0  0 ❌ ±0 
23 597 runs  ±0  22 815 ✅ ±0  782 💤 ±0  0 ❌ ±0 

Results for commit d1391ba. ± Comparison against base commit f27923b.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 9 times, most recently from 41d9bee to 03683f1 Compare September 25, 2025 03:41
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 03683f1 to ab6b8d6 Compare September 26, 2025 03:28
@akurtakov
Copy link
Member

@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed?

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from ab6b8d6 to 88bee99 Compare September 27, 2025 03:25
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 88bee99 to d1391ba Compare September 27, 2025 11:15
Integer.valueOf(fSize),
Integer.valueOf(fSize - fRemaining),
Integer.valueOf(fRemaining) });
return NLS.bind(JFaceTextMessages.getString("AsyncCompletionProposalPopup.computingDetails"), Integer.valueOf(fSize),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjohnstn Looks like the fix might need further adjustments as NON-NLS is still gone here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants