Updated setBlockOnOpen documentation #3210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing FileChooser from same dialog eclipse-platform#1599 Updated the documentation for the setBlockOnOpen function. The function seems to display different behaviors based upon the operating system being used to reproduce Issue eclipse-platform#1599. On MacOS reproducing the issue passes all test cases while Windows OS fails. Co-authored-by: Alejandro Navarro [email protected] Fixes eclipse-platform/eclipse.platform.swt#1599 (comment)
HeikoKlare
reviewed
Sep 6, 2025
There was a problem hiding this comment.
If there is a difference in behavior of that method depending on the operating system, wouldn't it be better to fix the behavior such that it is consistent across the operating systems?
If that's not possible, I would at least expect a more specific information that what is currently proposed. Just saying that the behavior can be different depending on the OS effectively renders the method useless, as a consumer does not know anything they can rely on then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWT Radio-Buttons resets radio-button selection after opening and closing FileChooser from same dialog #1599
Updated the documentation for the setBlockOnOpen function. The function seems to display different behaviors based upon the operating system being used to reproduce Issue #1599. On MacOS reproducing the issue passes all test cases while Windows OS fails.
Co-authored-by: Alejandro Navarro [email protected]
Fixes eclipse-platform/eclipse.platform.swt#1599 (comment)