-
Notifications
You must be signed in to change notification settings - Fork 209
misc: fix spelling #2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
misc: fix spelling #2885
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ | |
* <li><code>CheckboxCellEditor</code> - boolean valued checkbox</li> | ||
* <li><code>DialogCellEditor</code> - value from arbitrary dialog</li> | ||
* </ul> | ||
*/ | ||
Check warning on line 45 in bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/CellEditor.java
|
||
public abstract class CellEditor { | ||
|
||
/** | ||
|
@@ -691,8 +691,8 @@ | |
* | ||
* @param keyEvent | ||
* the key event | ||
*/ | ||
Check warning on line 694 in bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/CellEditor.java
|
||
protected void keyReleaseOccured(KeyEvent keyEvent) { | ||
protected void keyReleaseOccurred(KeyEvent keyEvent) { | ||
if (keyEvent.character == '\u001b') { // Escape character | ||
fireCancelEditor(); | ||
} else if (keyEvent.character == '\r') { // Return key | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ | |
* <p> | ||
* This class may be instantiated or subclassed. | ||
* </p> | ||
*/ | ||
Check warning on line 43 in bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TextCellEditor.java
|
||
public class TextCellEditor extends CellEditor { | ||
|
||
/** | ||
|
@@ -148,7 +148,7 @@ | |
// hook key pressed - see PR 14201 | ||
@Override | ||
public void keyPressed(KeyEvent e) { | ||
keyReleaseOccured(e); | ||
keyReleaseOccurred(e); | ||
|
||
// as a result of processing the above call, clients may have | ||
// disposed this cell editor | ||
|
@@ -236,8 +236,8 @@ | |
* may extend or reimplement. | ||
* | ||
* @param e the SWT modify event | ||
*/ | ||
Check warning on line 239 in bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TextCellEditor.java
|
||
protected void editOccured(ModifyEvent e) { | ||
protected void editOccurred(ModifyEvent e) { | ||
String value = text.getText(); | ||
if (value == null) { | ||
value = "";//$NON-NLS-1$ | ||
|
@@ -268,7 +268,7 @@ | |
*/ | ||
private ModifyListener getModifyListener() { | ||
if (modifyListener == null) { | ||
modifyListener = this::editOccured; | ||
modifyListener = this::editOccurred; | ||
} | ||
return modifyListener; | ||
} | ||
|
@@ -282,7 +282,7 @@ | |
* @since 3.0 | ||
*/ | ||
protected void handleDefaultSelection(SelectionEvent event) { | ||
// same with enter-key handling code in keyReleaseOccured(e); | ||
// same with enter-key handling code in keyReleaseOccurred(e); | ||
fireApplyEditorValue(); | ||
deactivate(); | ||
} | ||
|
@@ -385,7 +385,7 @@ | |
* @param keyEvent the key event | ||
*/ | ||
@Override | ||
protected void keyReleaseOccured(KeyEvent keyEvent) { | ||
protected void keyReleaseOccurred(KeyEvent keyEvent) { | ||
if (keyEvent.character == '\r') { // Return key | ||
// Enter is handled in handleDefaultSelection. | ||
// Do not apply the editor value in response to an Enter key event | ||
|
@@ -398,12 +398,12 @@ | |
if (text != null && !text.isDisposed() | ||
&& (text.getStyle() & SWT.MULTI) != 0) { | ||
if ((keyEvent.stateMask & SWT.CTRL) != 0) { | ||
super.keyReleaseOccured(keyEvent); | ||
super.keyReleaseOccurred(keyEvent); | ||
} | ||
} | ||
return; | ||
} | ||
super.keyReleaseOccured(keyEvent); | ||
super.keyReleaseOccurred(keyEvent); | ||
} | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this is API so it can not be changed as every downstream project will break . Please revert this part.