Skip to content

Conversation

@deepika-u
Copy link
Contributor

SWT Javadoc bash for 4.38

Fixes #2788

@deepika-u
Copy link
Contributor Author

@HeikoKlare
These are javadoc updates being generated by javadocbasher, can you take a look when you get some time.

But please dont close the task #2788, it is to be merged in RC2 only after verifying it.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Test Results

  118 files  ±0    118 suites  ±0   15m 36s ⏱️ - 2m 10s
4 653 tests ±0  4 635 ✅  - 1  18 💤 +1  0 ❌ ±0 
  338 runs  ±0    334 ✅ ±0   4 💤 ±0  0 ❌ ±0 

Results for commit 9fec50c. ± Comparison against base commit 28bb9b4.

This pull request skips 1 test.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_setUrl_remote_with_post

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

It looks like this PR does the opposite of what should be done. The deleted comment should instead be added in windows/mac javadoc too.

@deepika-u
Copy link
Contributor Author

Thanks for catching that! You’re absolutely right — I misunderstood the requirement and ended up doing the opposite of what was intended.
I’ll update the PR to add the latest changes.

@deepika-u deepika-u force-pushed the 4.38_javadoc_basher_changes branch 2 times, most recently from 8314654 to cfda7a6 Compare November 18, 2025 13:07
@deepika-u
Copy link
Contributor Author

I’ve updated the PR as per your suggestion - the changes are added now in Windows and Mac. Please review and let me know if everything looks good now.

@deepika-u deepika-u force-pushed the 4.38_javadoc_basher_changes branch from cfda7a6 to d0a0fee Compare November 20, 2025 05:44
@deepika-u
Copy link
Contributor Author

@akurtakov
Can you take a look at this when you get some time please?

@akurtakov akurtakov force-pushed the 4.38_javadoc_basher_changes branch from d0a0fee to 9fec50c Compare November 21, 2025 10:55
@jonahgraham
Copy link
Contributor

@deepika-u I'm not @akurtakov ;-) - but as a fellow committer I can offer a +1 on this javadoc change as it is the one that applies to to the discussion in this issue #2598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SWT Javadoc bash for 4.38

3 participants