-
Notifications
You must be signed in to change notification settings - Fork 186
Javadoc basher changes for 4.38 #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Javadoc basher changes for 4.38 #2789
Conversation
|
@HeikoKlare But please dont close the task #2788, it is to be merged in RC2 only after verifying it. |
Test Results 118 files ±0 118 suites ±0 15m 36s ⏱️ - 2m 10s Results for commit 9fec50c. ± Comparison against base commit 28bb9b4. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
|
It looks like this PR does the opposite of what should be done. The deleted comment should instead be added in windows/mac javadoc too. |
|
Thanks for catching that! You’re absolutely right — I misunderstood the requirement and ended up doing the opposite of what was intended. |
8314654 to
cfda7a6
Compare
|
I’ve updated the PR as per your suggestion - the changes are added now in Windows and Mac. Please review and let me know if everything looks good now. |
cfda7a6 to
d0a0fee
Compare
|
@akurtakov |
d0a0fee to
9fec50c
Compare
|
@deepika-u I'm not @akurtakov ;-) - but as a fellow committer I can offer a +1 on this javadoc change as it is the one that applies to to the discussion in this issue #2598 |
SWT Javadoc bash for 4.38
Fixes #2788