Extend ImageLoader to able to load images at a given target height and width #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d width Extend ImageLoader to able to load images at a given target height and width in addition to the current behaviour of only being able to load images at a target zoom. This is required to load images in svg format at custom height and width.
Test Results 546 files ±0 546 suites ±0 30m 36s ⏱️ - 1m 40s For more details on these failures, see this check. Results for commit 8cefbcf. ± Comparison against base commit 508ad4a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend ImageLoader to able to load images at a given target height and width in addition to the current behavior of only being able to load images at a target zoom. This is required to load images in svg format at custom height and width.
The extensions added in this change is used in #2526 That PR also contains snippets through which these changes are tested.
This depends on #2514, Only last commit is relevant for this PR