Make FontData key in map immutable #1994
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahzaibIbrahim
force-pushed
the
master-118
branch
from
96727c3 to
e563e26
Compare
Test Results 539 files ±0 539 suites ±0 35m 0s ⏱️ + 4m 54s For more details on these failures, see this check. Results for commit 493c646. ± Comparison against base commit c2136c9. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
master-118
branch
2 times, most recently
from
d64b33a to
76cde38
Compare
ShahzaibIbrahim
force-pushed
the
master-118
branch
from
76cde38 to
43b6a5f
Compare
Creating clone of FontData to be used as a key in map of ScalingSWTFontRegistry and DefaultSWTFontRegistry to make it immutable and inaccessible from outside of the class
fedejeanne
approved these changes
Apr 9, 2025
|
Failing test is unrelated #1843 |
HannesWell
reviewed
Apr 11, 2025
| @@ -72,7 +72,8 @@ public Font getFont(FontData fontData, int zoom) { | |||
| } | |||
|
|
|||
| private Font registerFont(FontData fontData, Font font) { | |||
| fontsMap.put(fontData, font); | |||
| FontData clonedFontData = new FontData(fontData.toString()); | |||
There was a problem hiding this comment.
This looks like a heavy-weight operation, creating a String just to parse it again.
Isn't there a (internal) copy-constructor or copy method that handles this more efficiently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating clone of FontData to be used as a key in map of ScalingSWTFontRegistry and DefaultSWTFontRegistry to make it immutable and inaccessible from outside of the class