Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] use fixed zoom for default system font #1969

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

akoch-yatta
Copy link
Contributor

This commit addresses a regression that is caused by DPIUtil#getDeviceZoom not properly initialized yet, when created the first system font. Explicitly passing the target zoom to the Font prevent the issue.

How to reproduce

Start a runtime on a zoom > 100 with default configuration (if not visible try a fresh workspace). The CTabFolder fonts will be bigger as expected

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Test Results

   539 files  ±0     539 suites  ±0   23m 45s ⏱️ - 1m 21s
 4 330 tests ±0   4 320 ✅ ±0  10 💤 ±0  0 ❌ ±0 
16 407 runs  ±0  16 309 ✅ ±0  98 💤 ±0  0 ❌ ±0 

Results for commit d41004f. ± Comparison against base commit f35ee7f.

♻️ This comment has been updated with latest results.

This commit addresses a regression that is caused by
DPIUtil#getDeviceZoom not properly initialized yet, when created the first
system font. Explicitly passing the target zoom to the Font prevent the
issue.
@akoch-yatta akoch-yatta force-pushed the fix-for-system-font branch from 9b2903b to d41004f Compare March 31, 2025 19:34
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is reasonable and it fixes the described issue.

@tobiasmelcher
Copy link
Contributor

Thanks a lot for the fix. Fix works on my side.

@fedejeanne
Copy link
Contributor

Ignoring unrelated check failure

@fedejeanne fedejeanne merged commit 5a117e1 into eclipse-platform:master Apr 1, 2025
11 of 15 checks passed
@fedejeanne fedejeanne deleted the fix-for-system-font branch April 1, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fonts too big without monitor specific scaling active
4 participants