Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32] Fix DnD across multiple monitors #1967

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akoch-yatta
Copy link
Contributor

@akoch-yatta akoch-yatta commented Mar 31, 2025

This PR addresses issues, when DnD across multiple monitors with monitors specific scaling is used. If the monitors have different zoom dragging into a table or tree on the second monitor will detect the wrong destination items depending on the zoom. To address this the zoom should always be inherited from the underlying control if available.

How to test

Test setup

Monitor setup with two different monitors:

  • Primary should be the smaller zoom (e.g. 100)
  • Secondary should be the bigger zoom (e.g. 150)
  • Start the runtime IDE with monitor specific scaling active

Test scenario

  1. Open and position the IDE on the secondary monitor and the File explorer on the primary monitor
  2. Open the Project explorer with at least one project to drag into
  3. Drag a file from the File explorer over to the project
  4. You will notice the hover overlay does not highlight the correct entry

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Test Results

   539 files  ±0     539 suites  ±0   37m 53s ⏱️ + 8m 56s
 4 330 tests ±0   4 320 ✅ ±0    9 💤 ±0  1 ❌ ±0 
16 579 runs  ±0  16 477 ✅ ±0  101 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 9fd4c4a. ± Comparison against base commit 0f21a6e.

♻️ This comment has been updated with latest results.

@akoch-yatta akoch-yatta force-pushed the fix-dnd-across-monitors branch from af218d2 to 8fd4c01 Compare March 31, 2025 10:39
@akoch-yatta akoch-yatta marked this pull request as draft March 31, 2025 11:48
@akoch-yatta akoch-yatta force-pushed the fix-dnd-across-monitors branch from 8fd4c01 to 14d5d9e Compare April 1, 2025 08:45
This commit addresses issues, when DnD across multiple monitors with
monitors specific scaling is used. If the monitors have different zoom
dragging into a table or tree on the second monitor will detect the wrong
destination items depending on the zoom. To address this the zoom should
always be inherited from the underlying control if available.
@akoch-yatta akoch-yatta force-pushed the fix-dnd-across-monitors branch from 14d5d9e to 9fd4c4a Compare April 4, 2025 08:30
@akoch-yatta akoch-yatta marked this pull request as ready for review April 4, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong drop position on non-primary monitor
1 participant