[win32] Explicit zoom handle management #1901
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 509 files ±0 509 suites ±0 9m 31s ⏱️ + 1m 2s For more details on these failures, see this check. Results for commit bfc5ed8. ± Comparison against base commit 011a490. ♻️ This comment has been updated with latest results. |
akoch-yatta
force-pushed
the
extract-imagehandle-management
branch
from
cb2caf9 to
a8a9589
Compare
This commit adapt the win32 implementation of Image to manage the map contains all available OS handle more explicitly. As of now the ImageHandle constructor adds all new handles directly to the map. To better support temporary image handles, this implicit adding is replaced by an explicit adding at convenience method to create new ImageHandles.
akoch-yatta
force-pushed
the
extract-imagehandle-management
branch
from
a8a9589 to
bfc5ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapt the win32 implementation of Image to manage the map contains all available OS handle more explicitly. As of now the ImageHandle constructor adds all new handles directly to the map. To better support temporary image handles, this implicit adding is replaced by an explicit adding at convenience method to create new ImageHandles.