Skip to content

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Sep 25, 2025

Unify the previously two jobs to mark a build as stable and unstable into one pipeline job, that has a choice parameter for the type of marker to apply.

This allows to reduce the number of jobs from two to one and also allows to extend to types of markers to apply. For example to have a RETAINED_INDEFINITELY (respectively its reverse NOT_RETAINED), which will prevent the automated clean-up jobs from potentially deleting a specific I- or Y-build drop (for any reasons) or even an old release, as I have already drafted in

For the occasional task to mark a build as unstable (or stable again, which seldomly happens) the following replacements apply

I have renamed unstable to NOT_STABLE to match the choices I plan to add, as described above. But if you prefer UNSTABLE, I can also use that. The choices continue to be STABLE and UNSTABLE.
@iloveeclipse, @akurtakov, @merks or @HeikoKlare FYI as I assume you are the ones that mark builds as unstable if necessary.

@HeikoKlare
Copy link
Contributor

Sounds good to me. Just a nitpick: maybe we can rather call it something like "Mark stability" instead of "Mark build" to have a less generic name?

@HannesWell
Copy link
Member Author

Sounds good to me. Just a nitpick: maybe we can rather call it something like "Mark stability" instead of "Mark build" to have a less generic name?

Thanks. Because I want to extend the job's capabilities with subsequent PRs (as described above), I think the job name and thus URL should be generic. But making the display name more specific (and extending it accordingly in subsequent changes), sounds good to me. I'm about to change the display name to Mark build stability.

@HannesWell HannesWell force-pushed the unify-mark-build-jobs branch from 364b745 to a1a62c7 Compare September 26, 2025 17:54
@HeikoKlare
Copy link
Contributor

Because I want to extend the job's capabilities with subsequent PRs (as described above)

Ah, I missed that sentence. Thank you for the explanation. I just saw the other mark-build-... job in Jenkins, but that's obviously only a test job of yours 🙂 Then it would also be okay for me to just stick to the initial name you proposed.

Unify the previously two jobs to mark a build as stable and unstable
into one pipeline job, that has a choice parameter for the type of
marker to apply.
@HannesWell HannesWell force-pushed the unify-mark-build-jobs branch from a1a62c7 to 1b3b5f4 Compare September 26, 2025 20:59
@HannesWell
Copy link
Member Author

Because I want to extend the job's capabilities with subsequent PRs (as described above)

Ah, I missed that sentence. Thank you for the explanation. I just saw the other mark-build-... job in Jenkins, but that's obviously only a test job of yours 🙂 Then it would also be okay for me to just stick to the initial name you proposed.

Yes. Testing in advance avoids noise in git and trouble for me and all of those that want to use it 😅

Then it would also be okay for me to just stick to the initial name you proposed.

Yes. Thinking about it again, even the display name shouldn't be too verbose (yet still clear). But we can add more explanations in the description.

Thanks for your input.

@HannesWell HannesWell merged commit a3536c1 into eclipse-platform:master Sep 26, 2025
5 of 6 checks passed
@HannesWell HannesWell deleted the unify-mark-build-jobs branch September 26, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants