Fixing minor issues and add some missing repos #28
Conversation
Signed-off-by: Philippe Krief <[email protected]>
|
Thanks for reviewing @philipreimer |
Signed-off-by: Philippe Krief <[email protected]>
Signed-off-by: Philippe Krief <[email protected]>
|
Dear @philipreimer |
| @@ -113,7 +113,8 @@ elif [ $KIND_OF = "Nodes" ]; then | |||
| echo ": DASH Analysis > " $ANALYSIS_RESULT_FILE | |||
| echo ": DASH Analysis > " $ANALYSIS_RESULT_FILE >> $LOG_FILE | |||
| java -jar $DASH_LIB $JSON_FILE -summary $ANALYSIS_RESULT_FILE >> $LOG_FILE | |||
| cp $SRC_DIR/package-lock.json $DEST_DIR | |||
| cp $SRC_DIR/package.json $DEST_DIR | |||
| cp $SRC_DIR/yarn.lock $DEST_DIR | |||
There was a problem hiding this comment.
| cp $SRC_DIR/yarn.lock $DEST_DIR | |
| cp $SRC_DIR/package-lock.json $DEST_DIR |
I think this should be package-lock.json because a node project typically does not have a yarn.lock file.
IPCheck/parseAll.sh
Outdated
| ./dashAnalysis.sh "Maven" "$SRC_REPO/kie-wb-distributions" "$DST_REPO/kie-wb-distributions" | ||
|
|
||
| #./dashAnalysis.sh "N/A" "$SRC_REPO/smartclide" "$DST_REPO/smartclide" | ||
| #./dashAnalysis.sh "Maven" "$SRC_REPO/smartclide-api-gateway" "$DST_REPO/smartclide-api-gateway" |
There was a problem hiding this comment.
Why are all the repos commented out now? Should they not be checked?
| @@ -0,0 +1,2 @@ | |||
| #!/bin/bash | |||
| ./parseAll.sh "/Users/philippe/git" "/Users/philippe/temp/smartclide/analysis" | |||
There was a problem hiding this comment.
Maybe put parseThemAll.sh and parseThisOne.sh as examples into a README.md file?
I would suggest not to include them as source files - at least not as they are now - because they contain file paths that are specific for your machine.
|
Dear @phkrief Unfortunately, I still have some questions / suggestions. |
1 similar comment
|
Dear @phkrief Unfortunately, I still have some questions / suggestions. |
Signed-off-by: Philippe Krief <[email protected]>
Signed-off-by: Philippe Krief [email protected]