refactor(application): move navigation module interface to api package #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
INavigationModule
andIRoutingModule
were misplaced inside the implementation package.NavigationModule
andRoutingModule
and were moved toorg.eclipse.mosaic.fed.application.app.api.navigation
package to improve consistency.NavigationModule
, which implements both interfaces, has been renamed toRoutingNavigationModule
, to 1) avoid name clash with the interface, and 2) to make more clear that it implements both interfaces.retrieveAllValidRoutesToTarget(..)
has been removed fromNavigationModule
interface as it was not used and does also makes no sense from a navigation module point of view, as it is more of a helper method for theCentralNavigationComponent
. No replacement is offered, as it was not required in any of our existing models.Issue(s) related to this PR
Affected parts of the online documentation
Yes, code examples in https://eclipse.dev/mosaic/docs/develop_applications/navigation/ must be adjusted.
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer