Allow re-use by making these public with a public constructor#946
Allow re-use by making these public with a public constructor#946zenbones wants to merge 1 commit intoeclipse-ee4j:2.2.1-BRANCHfrom
Conversation
|
I've signed an ECA but can't link my GitHub account because my GitHub user name is the same as my Eclipse user name (because no one said I should not) and when I try to link my GitHub account the application tells me there's already a user by that user name, I assume me? Not sure what else I can do. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Had 2 accounts... my fault. Removed the github link from the old one, now I have a signed ECA and teh github account linked, so hopefully this will clear? |
|
Revalidated ECA check now. |
|
Fine with me. Private by default was likely done to allow some freedom in refactoring. Now it's public API and we should not just change it. But it's interesting that people use Tyrus in this way. Leaving the PR open for a short while to see if anyone from the team has additional comments, and if not I'll merge it. (I'm not a super active committer in Tyrus, so I would like to see some comments from more active people) |
|
The PR is made into a wrong branch, 2.2.1 is a technical branch for a release. 2.x is the development branch from which 2.2.2 will be released. |
@zenbones can you edit this PR and change target branch? |
Since there's a 2.0.x and 2.1.x, should maybe 2.x be called 2.2.x instead? |
4 participants
WebSocketAddOn should definitely be public in a way that allows re-use. We construct our grizzly server via spring, with a few modification, and I would like to be able to add Tyrus without having to create my own versions of WebSocketAddOn and/or GrizzlyServerFilter. We currently do both, and although add-on is simple, GrizzlyServerFilter is not, and you are just enforcing a pain point for no reason I can discern. This is an open source project. I pould like to make WebSocketAddOn re-usable by providing a public constructor on this already public class, and, for good measure, making GrizzlyServerFilter a public class to go with its already public constructor. This helps us greatly and I can see no harm.