Brotli support #5202
Draft
Brotli support #5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tvallin <[email protected]>
Signed-off-by: tvallin <[email protected]>
|
I believe we cannot make Brotli a default dependency. Rather, it would reside in a separate module. While brotli impl is in a testing phase, I'd see the module under the incubator, until some maturity is reached. |
Signed-off-by: tvallin <[email protected]>
jansupol
reviewed
Dec 1, 2022
| @@ -0,0 +1,37 @@ | |||
| package org.glassfish.jersey.message; | |||
There was a problem hiding this comment.
I do not believe it is a good idea to have the same package name in two modules, and org.glassfish.jersey.message is in core-common already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR because brotli is not released yet.
Signed-off-by: tvallin [email protected]