Fix principal in Jakarta SecurityContext when using SSO #25356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a thread-local field in the securityContext field.
OndroMih
force-pushed
the
ondromih-sso-issue
branch
2 times, most recently
from
21241b9 to
104c9c9
Compare
dmatej
reviewed
Feb 4, 2025
...erver/itest-tools/src/main/java/org/glassfish/main/itest/tools/GlassFishTestEnvironment.java
Show resolved
Hide resolved
pzygielo
reviewed
Feb 4, 2025
...tion/src/main/java/org/glassfish/main/test/app/security/jakartasecurity/CustomPrincipal.java
Outdated
Show resolved
Hide resolved
OndroMih
force-pushed
the
ondromih-sso-issue
branch
from
104c9c9 to
9e1d4a2
Compare
Add tests for Jakarta Security authentication - test for a custom principal - test for serialization of the internal securityContext, which is transferred across SSO instances Some refactoring - remove redundant empty lines from SimpleMultiRoleMappingTest - add an alternative to test HTTP resources with Java Http Client to GlassFishTestEnvironment
OndroMih
force-pushed
the
ondromih-sso-issue
branch
from
9e1d4a2 to
073f35d
Compare
hs536
reviewed
Feb 5, 2025
nucleus/security/core/src/main/java/com/sun/enterprise/security/SecurityContext.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebPrincipal was not serializable because of this fix: #25290, which caused exceptions in SSO mechanism, like this:
This PR moves the thread local variable to the static context so that it's not serialized together with securityContext instance. The value is only relevant within a scope of a specific request, and thus within a specific thread, so it doesn't have to be attached to a specific security context instance.