-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic develocity setup #25322 #25336
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Seems to be flaky test:
Is there already some value hidden in these build scans (compared here) that could help us understand that better and fix |
514f452
to
e5a45b9
Compare
@pzygielo Re: flaky tests: No, Develocity by default doesn't gather more data by default, other than what's reported to the console log and part of the failure stacktace. If you know what data you'd be interested in, you can extend the build scan. It looks like the org.glassfish.grizzly.config.HttpRedirectTest tests are the only flaky tests picked up - at least from the runs published until now. Unrelated to this issue, but I'd recommend adding the profiles the build was executed with (at least on CI) as a custom value - this would allow you to also filter out just the runs with a specific profile, which might be useful since pretty much all your CI builds run |
Hi @pzygielo, are there any open questions on this front? I'm very excited about introducing build caching to your build (which builds upon this PR), as that can give you some substantial build time savings. I've got two PRs prepared for that: basic caching PR ribafish#1 and additional assciidoctor caching config PR ribafish#2 - I'm also happy to merge those two, I just kept them separate to allow you to decide and test them separately. Note: the failed CI build is happening because of some (flaky) tests failing: https://develocity-staging.eclipse.org/s/pbhorem2egira/tests/overview?outcome=FAILED |
With secrets in place (https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5546), this is based on required in first step
and this restores