Shoal 4.0.0 - JPMS, Grizzly5 #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…grade - It had to be done at once as all these things are related - org.shoal.adapter.store package was spread over two jar files, had to be renamed - com.sun.enterprise caused some reflection issues then, so I decided to align all shoal modules under org.glassfish.shoal - impl packages are not automatically added to OSGI bundle, but were used from the outside, also Felix complained, so I renamed them too. - Added JPMS module-info files, Felix works with them quite well Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej
added
bug
10 tasks
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…er versions Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
OndroMih
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.glassfish.shoalnow.Tested with eclipse-ee4j/glassfish#25859 (with Grizzly 5.0.0-SNAPSHOT)