Skip to content

POM Cleanup and removed unused imports in java sources#2274

Merged
arjantijms merged 13 commits intoeclipse-ee4j:mainfrom
dmatej:grizzly5cleanup
Jan 13, 2026
Merged

POM Cleanup and removed unused imports in java sources#2274
arjantijms merged 13 commits intoeclipse-ee4j:mainfrom
dmatej:grizzly5cleanup

Conversation

@dmatej
Copy link
Contributor

@dmatej dmatej commented Jan 12, 2026 •
edited
Loading

  • Unused imports were reported by Checkstyle in my Eclipse workspace
  • Defining plugins in BOM was not much useful, rather confusing
  • I added proper names to all POMs and also descriptions to some of them.
  • Fixed version in OSGI headers - using version=${project.version} is toxic with snapshots (and dashes), while Felix plugin is smart enough to resolve it on its own.
  • I switched from bundle artifact type to jar file generating manifest. It is more readable.
  • The bundles subdirectory unpacked zips and jars to src directory, then deleted it after processing. Now uses target directory, which is a standard maven convention.
  • Updated Metro dependencies (patch release), Mockito and Jersey
  • Added module-info to http-server-multipart

Effects

Tested also together with eclipse-ee4j/glassfish#25859 and all projects in this context.

dmatej added 13 commits January 7, 2026 18:56
@dmatej
Removed unused imports
e231365 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Generics in http2 package, calling getInstance just once
470aed7 
- Eclipse complained, I had it here maybe 3 years :-)

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Added module-info to the multipart module
4564cc5 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Using jpms in samples multipart
e1b445a 
- Eclipse IDE complained

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Updated mockito in http-server test
5b48695 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Synced BOM to the parent and removed required java version
b793512 
- The Java version is not used by this bom.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
The plugin management from BOM moved to the parent
ce3f4ba 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Updated Jersey and RS-API dependencies
d4cf253 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Our property files are in Latin1 encoding
757e194 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Fixed URL in poms to link Grizzly website
1198fc3 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
All modules now have a name, some also description
8d14216 
- I added also some prefixes to names to separate few types of modules

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Jakarta Servlet API should be a provided dependency
d2734b3 
- This fixes Bundles which included repackaged servlet api jar file

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Revisited poms and way we package Grizzly
9ea4699 
- Removed duplicit surefire configuration
- Removed redundant groupIds
- Replaced bundle lifecycle with just manifest generation
- Removed usages of project.version in OSGI as it breaks snapshots
- Bundles now use target directory instead of using src and then deleting it
- Fixed transitive dependency on Servlet, which was then included into bundles
  - however it seems sometimes it was intentional


Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej added this to the 5.0.0 milestone Jan 12, 2026
@dmatej dmatej self-assigned this Jan 12, 2026
@dmatej dmatej mentioned this pull request Jan 12, 2026
Merged
10 tasks
@dmatej dmatej marked this pull request as ready for review January 13, 2026 17:24
@dmatej dmatej requested review from a team January 13, 2026 17:24
@dmatej dmatej added dependencies Pull requests that update a dependency file refactoring labels Jan 13, 2026
@arjantijms arjantijms merged commit 8d5485d into eclipse-ee4j:main Jan 13, 2026
3 checks passed
@dmatej dmatej deleted the grizzly5cleanup branch January 13, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees

@dmatej dmatej

Labels

dependencies Pull requests that update a dependency file refactoring

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Bundles grizzly-http and grizzly-core, grizzly-http-server-core, ...: Split package, multiple jars provide the same package

2 participants

@dmatej @arjantijms