Fix constexpr execution of if statement with static_assert declaration substatement #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-garrison
force-pushed
the
feature/constexpr-execute-static-assert
branch
3 times, most recently
from
b94bc49 to
3cc59d9
Compare
Test Results 584 files - 34 584 suites - 34 13m 47s ⏱️ - 22m 26s For more details on these failures, see this check. Results for commit e17148d. ± Comparison against base commit 48065ad. This pull request removes 1217 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…n substatement Stop null dereference in ExecIf when thenClauseExec is null. This happens with throw declaration in thenClause, and ExecIf already allows for null in elseClauseExec so this is a bit more consistent. Null thenClauseExec can be from encountered valid static_assert declaration, handle it during constexpr execution as new special problem type STATIC_ASSERT_FAILED.
i-garrison
force-pushed
the
feature/constexpr-execute-static-assert
branch
from
3cc59d9 to
e17148d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop null dereference in ExecIf when thenClauseExec is null. This happens with throw declaration in thenClause, and ExecIf already allows for null in elseClauseExec so this is a bit more consistent.
Null thenClauseExec can be from encountered valid static_assert declaration, handle it during constexpr execution as new special problem type STATIC_ASSERT_FAILED.
Fix these and add unit test.