add event trigger function block #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this FB will trigger all unconnected events of the specified type within a resource on REQ
oberlehner
reviewed
Jan 9, 2025
| @@ -0,0 +1,26 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <FBType Name="E_TRIG" Comment="Trigger FB for a specified Event Type" > | |||
There was a problem hiding this comment.
i dont like the name and the comment. For me its not really clear what this block should do.
If the name is defined by the IEC 61499 standard, then i would leave it like, otherwise we should give it a more descriptive way that makes it clear that all blocks with the event type will be triggered.
@azoitl what do you think about that ?
There was a problem hiding this comment.
I would also go for an improved comment. There is no name in the standard for this block. But I thought keeping it short and simple and in line with existing blocks (E_RTRIG, E_FTRIG) would be a good idea.
| </Event> | ||
| </EventOutputs> | ||
| <InputVars> | ||
| <VarDeclaration Name="EVENTTYPE" Type="STRING" Comment="Event type to be triggered" /> |
There was a problem hiding this comment.
'EInit' could be a sensible InitialValue for EVENTTYPE?
azoitl
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This FB will trigger all unconnected events of the specified type within a resource on REQ
related to https://github.com/eclipse-4diac/4diac-forte/pull/298