closes #19 with basic type checking #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added constant folding logic to evaluate array sizes at compile time. - Updated error handling for negative and invalid sizes. - Modified test cases to reflect changes in expression handling.
- Introduced a new `Array` variant in the `Expression` enum to represent array expressions. - Implemented a `new_array` method for creating array expressions. - Updated the type inference logic to handle array expressions in the type pass. - Enhanced the `Type` enum with a display implementation for better type representation. - Added a structure for managing type environments, allowing for nested scopes and type resolution. This commit lays the groundwork for future array expression handling in the parser and type system.
- Simplified the `Array` variant in the `Expression` enum to use a tuple struct for better clarity. - Enhanced the `TokenKind` enum with a `Display` implementation for improved string representation of tokens. - Updated type inference logic to accommodate the new `Array` structure. - Added comprehensive tests for type inference, including support for arrays and various expression types. These changes streamline the AST and type inference process, laying the foundation for more robust expression handling in the type system.
- Reformatted struct and function declarations in `ast.rs` for better readability. - Updated `FnSig` type alias in `types.rs` to simplify function signature handling. - Modified type inference functions in `type_pass.rs` to accept mutable references to `TypeEnv`, enhancing type environment management. - Added new type checking functions for statements, improving type validation during the inference process. - Enhanced tests to ensure proper type inference and error handling across various expression and statement types. These changes streamline the AST structure and type inference logic, paving the way for more robust type checking in the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a very basic naive type checker loosely based on algorithm W