-
Notifications
You must be signed in to change notification settings - Fork 97
[1488] Support frequency nominal dim in consolidate functions #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dbashford-NOAA
wants to merge
99
commits into
echostack-org:main
from
dbashford-NOAA:1488_support_frequency_nominal_in_consolidate_functions
Closed
Changes from 2 commits
Commits
Show all changes
99 commits
Select commit
Hold shift + click to select a range
7c0653d
[1488] Support frequency nominal dim in consolidate functions and upd…
dbashford-NOAA 2e1c814
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb25040
[1486] Support computing MVBS with frequency_nominal and fix some tes…
dbashford-NOAA a84334e
chore(deps): bump actions/download-artifact from 4 to 5 (#1529)
dependabot[bot] a75a56c
chore(deps): bump actions/checkout from 4 to 5 (#1528)
dependabot[bot] 85ce376
chore(deps): bump actions/cache from 4.2.3 to 4.2.4 (#1527)
dependabot[bot] f0c95e8
[pre-commit.ci] pre-commit autoupdate (#1526)
pre-commit-ci[bot] 102cb9d
Update pr.yaml to run full test suite for all PR (#1524)
LOCEANlloydizard ed6c267
[1488] Create consolidate tests that include dim swapping
dbashford-NOAA ec182f1
chore(deps): bump pypa/gh-action-pypi-publish in /.github/workflows (…
dependabot[bot] b55552d
chore(deps): bump actions/setup-python from 5.5.0 to 6.0.0 (#1535)
dependabot[bot] bb33278
[pre-commit.ci] pre-commit autoupdate (#1538)
pre-commit-ci[bot] cdbf6f8
Add weill to codespell ignore list (#1543)
LOCEANlloydizard a48f3a2
Implementations of basic seafloor detection in mask subpackage [all t…
LOCEANlloydizard ff2638e
[1488] Swap beam group dims in consolidate functions if needed
dbashford-NOAA cb78b56
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0a6842f
[1488] Fix f-string placeholder error
dbashford-NOAA df6c82d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1b9dc99
[1541] Remove python 3.10 support (#1546)
dbashford-NOAA 46fcb67
chore(deps): bump actions/cache from 4.2.4 to 4.3.0 (#1547)
dependabot[bot] 3ffe8f3
Add Fielding and Matecho-like transient noise removal methods (#1544)
LOCEANlloydizard 0dffd51
Shoals detection implementation [all tests ci] (#1525)
LOCEANlloydizard a2cfade
Modifications to match xarray update to v2025.9.1 (#1550)
LOCEANlloydizard 29e6153
[1488] Re add ed ds compare for add_depth
dbashford-NOAA 4d7c8cc
Update docstrings for transient noise and shoal detection functions
LOCEANlloydizard 7dbcf5b
[pre-commit.ci] pre-commit autoupdate (#1555)
pre-commit-ci[bot] f95f7a4
fix(ci): free disk space to resolve "No space left on device" during …
LOCEANlloydizard 058333e
[1542] Support python 3.13 (#1553)
dbashford-NOAA c5a1373
Merge remote-tracking branch 'upstream/main'
LOCEANlloydizard 47f9cb2
Apply suggestions from code review
LOCEANlloydizard daf3b17
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2d08598
[pre-commit.ci] pre-commit autoupdate (#1559)
pre-commit-ci[bot] faa3936
chore(deps): bump actions/setup-python from 5.5.0 to 6.0.0 (#1560)
dependabot[bot] bb2cd25
Updated after review
LOCEANlloydizard 71b67ab
[1428/1512] Migrate to numpy v2 and zarr v3 with updated test_data pa…
dbashford-NOAA be1ea10
Review Blackwell docstring: fix indentation and replace 'clamp' with …
LOCEANlloydizard f479cf3
small tweak re adaptive Sv threshold
leewujung be8b60c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 98bed9f
Update docstrings for transient noise and shoal detection functions (…
LOCEANlloydizard 39e3de2
CI: Pooch assets + Windows fixes, HTTP/S3 test setup, Windows runner …
LOCEANlloydizard e0d9d4c
Restore small comments from original pr.yaml
LOCEANlloydizard 3600e47
CI: switch to Pooch-managed GitHub assets and remove local test_data …
LOCEANlloydizard 0ea9350
add push to main to tests workflow in additional to PR
leewujung 2c9b49f
update build.yaml to use pooch
leewujung d917fb9
test data endpoint
leewujung 7fd42ff
remove trailing white space
leewujung 9f5f575
change name back to test PR
leewujung e2d06da
Merge pull request #1566 from leewujung/push_workflow_patch
LOCEANlloydizard 778833f
Merge branch 'main' of https://github.com/OSOceanAcoustics/echopype
LOCEANlloydizard 2fd76b1
ci: fix Pooch asset cache key mismatch in build workflow
LOCEANlloydizard d48eb6e
Update pr.yaml
LOCEANlloydizard 253c437
Merge from latest upstream
LOCEANlloydizard 5ab10d6
Update conftest.py
LOCEANlloydizard a26f069
Merge pull request #1567 from LOCEANlloydizard/ci/fix-asset-cache-key
LOCEANlloydizard e6374c7
Merge pull request #1563 from LOCEANlloydizard/CI_windows
LOCEANlloydizard f96a149
chore(deps): bump actions/download-artifact from 5 to 6 (#1568)
dependabot[bot] ebe1d44
chore(deps): bump actions/upload-artifact from 4 to 5 (#1569)
dependabot[bot] 12dee97
Update test_ecs_integration.py (#1575)
LOCEANlloydizard 520914c
Use official http image and using Pooch to pull data to http server (…
leewujung 175aec7
chore(deps): bump actions/checkout from 5 to 6 (#1576)
dependabot[bot] 72a9bf5
Setup python_requires >=3.11 in setup.cfg (#1561)
leewujung 4275947
chore(deps): bump actions/setup-python from 6.0.0 to 6.1.0
dependabot[bot] e9ab229
Merge pull request #1580 from OSOceanAcoustics/dependabot/github_acti…
LOCEANlloydizard d371686
update azfp6 sha256 and version tag
leewujung 82925a1
Merge pull request #1582 from leewujung/update_azfp6_asset
LOCEANlloydizard 1f26305
[pre-commit.ci] pre-commit autoupdate (#1583)
pre-commit-ci[bot] 527ab56
chore(deps): bump actions/download-artifact from 6 to 7
dependabot[bot] 74e00b6
chore(deps): bump actions/upload-artifact from 5 to 6
dependabot[bot] 20c0674
chore(deps): bump actions/cache from 4 to 5
dependabot[bot] 0495644
Merge pull request #1584 from OSOceanAcoustics/dependabot/github_acti…
LOCEANlloydizard fc1ff8c
Merge pull request #1585 from OSOceanAcoustics/dependabot/github_acti…
LOCEANlloydizard 9165ca4
Merge pull request #1586 from OSOceanAcoustics/dependabot/github_acti…
LOCEANlloydizard 8b46763
Update test_commongrid_api.py
LOCEANlloydizard 4ee7e06
Update conftest.py
LOCEANlloydizard a604ef0
Merge branch 'main' into fix_numpy_update_2.4
LOCEANlloydizard 889ece3
Update conftest.py
LOCEANlloydizard 3f9ee07
Merge branch 'fix_numpy_update_2.4' of https://github.com/LOCEANlloyd…
LOCEANlloydizard f6dbf48
Update pr.yaml
LOCEANlloydizard c5053d2
Update pr.yaml
LOCEANlloydizard 632f3ef
Update conftest.py
LOCEANlloydizard 50998eb
change data version
LOCEANlloydizard 6e7a17e
trigger test run after restoring v0.11.1a1 azfp.zip
leewujung 822bc84
Update AZFP test data in v0.11.1a2 assets (#1593)
leewujung 8505ec9
Merge branch 'main-upstream' into fix_numpy_update_2.4
leewujung fcee56d
Merge pull request #1591 from LOCEANlloydizard/fix_numpy_update_2.4
LOCEANlloydizard 04c5a58
chore(deps): bump tj-actions/changed-files from 45 to 47
dependabot[bot] b476498
Merge pull request #1594 from OSOceanAcoustics/dependabot/github_acti…
LOCEANlloydizard 4243633
Investigating the disk space failure in CI (#1592)
LOCEANlloydizard 6e2e496
[1488] Support frequency nominal dim in consolidate functions and upd…
dbashford-NOAA 625ed49
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c3c0e15
[1488] Create consolidate tests that include dim swapping
dbashford-NOAA 4af91e1
[1488] Swap beam group dims in consolidate functions if needed
dbashford-NOAA db61d00
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e42aaf3
[1488] Fix f-string placeholder error
dbashford-NOAA 4b36e0e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1cf0f4a
[1488] Re add ed ds compare for add_depth
dbashford-NOAA 2801cdf
Merge remote-tracking branch 'origin/1488_support_frequency_nominal_i…
dbashford-NOAA cfbb966
[1488] Remove dim_0 switching inside functions and refine testing for…
dbashford-NOAA 1b30b30
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the current implementation
is a weird setup in terms of Beam_groupX selection. This is a larger issue so no immediate actions required under this PR, but I will note this in a separate issue.