CI: Zizmor fixes others #539
Open
+354
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
force-pushed
the
zizmor-fixes-others
branch
from
5465052 to
4cd8a05
Compare
…ions Solves zizmor's template-injection audit: https://docs.zizmor.sh/audits/#template-injection
…flow - Use env vars directly instead of template substitution - This includes renaming env var CMakeVersion to CMAKE_VERSION - Double quote variables, and add braces
…ble quoted if ever used
…orkflow - Use env vars directly instead of template substitution - Double quote variables, and add braces - Declare and assign exported env vars separately to avoid masking return values. (SC2155)
…_draft.yml workflow
echoix
force-pushed
the
zizmor-fixes-others
branch
from
2e499a1 to
af58dd0
Compare
To the best of my knowledge and after another review, this workflow is most appropriate to be used with pull_request_target limited to closed and merged PRs.
…te_app.yml workflow
…te_app.yml workflow
…e env var instead
…yml workflow Two ShellCheck issues should be fixed later on regarding the use of ls in a for loop.
…flow Fixes a cache-poisoning issue reported by zizmor Two separate steps are used. It is assuming that the push event is not used for tags and that these artifacts (using cache) are not published as release artifacts
…ential cache-poisoning
…emplate injection
…ality.yml workflow
Cache poisoning is less problematic here as pytest workflow not really used for release artifacts
Cache poisoning is less problematic here as python-code-quality workflow not really used for release artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.