Skip to content

trim_trailing_whitespace togehter with insert_final_newline does not work #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BaumiCoder wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

trim_trailing_whitespace togehter with insert_final_newline does not work #136

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
267010e
trim and final newline together fails
BaumiCoder Dec 21, 2025
aef1034
Expect system eol character without eol property
BaumiCoder Dec 21, 2025
2d682a0
Use system line breaks for test strings
BaumiCoder Dec 22, 2025
e520f9a
Rename test
BaumiCoder Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions editorconfig-linters/src/test/java/org/ec4j/linters/TextLinterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,32 @@ public void insert_final_newline() throws IOException {
PropertyType.insert_final_newline.getName(), "true"));
}

@Test
public void insert_final_newline_system_eol() throws IOException {
final ResourceProperties props = ResourceProperties.builder() //
.property(new Property.Builder(null).type(PropertyType.insert_final_newline).value("true").build()) //
.property(new Property.Builder(null).type(PropertyType.trim_trailing_whitespace).value("true").build()) //
.build();
String text =
"line 1" + System.lineSeparator() + //
"line 2 " + System.lineSeparator() + //
"line 3"//
;
String expectedText =
"line 1" + System.lineSeparator() + //
"line 2" + System.lineSeparator() + //
"line 3" + System.lineSeparator() //
;
Resource doc = LinterTestUtils.createDocument(text, ".txt");

LinterTestUtils.assertParse(linter, doc, expectedText, props, //
new Violation(doc, new Location(2, 7), new Delete(4), linter,
PropertyType.trim_trailing_whitespace.getName(), "true"),
new Violation(doc, new Location(3, 7),
Insert.endOfLine(EndOfLineValue.ofEndOfLineString(System.lineSeparator())), linter,
PropertyType.insert_final_newline.getName(), "true"));
}

@Test
public void insert_final_newline_empty() throws IOException {
final ResourceProperties props = ResourceProperties.builder() //
Expand Down