fix(i2c.py): remove exception for valid API call #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the delay. It seems legit, but it is missing some unit test cases to validate it |
Owner
|
See 42efd8e (rebase/resolve) |
Author
Just reviewed it, it looks good. Do you want me to create a new PR based on that? Let me know whether you want some unit testing from me? |
Owner
It would be very nice if you could add some test with a basic I2C device to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #359
I considered converting it to a
self.log.warning(),but the API documentation states areadlenof 0 is valid so it doesn't make sense to warn the developer about that.Blame indicates these lines are 8 years old (0701df6), so it was probably just overlooked, unnecessary developer safety net.
P.S. Great work on this library!!!! 🎉 🎉 🎉
Tested with FTDI FT2232HQ found in the Tigard