You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
There are some issues, possibly related to ggplot 3.5 (not definitely certain yet), and people possibly need to downgrade ggplot to work with see. (easystats/performance#691).
Until it's not clear what's going on, I wanted to make sure that others still can use our packages
The reason will be displayed to describe this comment to others. Learn more.
But isn't GitHub using latest ggplot independent from which version we specify on DESCRIPTION? Else, we could add a skip-if-minimum version to snapshot tests, but it's more important to have dev versions work for all users
The reason will be displayed to describe this comment to others. Learn more.
Yes, our CI always tries to use the latest version of packages. But I am not sure why you think anything is broken for our users because of the ggplot2 update; we have no concrete evidence to believe that. Currently, users only get some additional warnings when they use see or performance, but there was no breaking change for us coming from ggplot2 update.
The issue Ben is mentioning seems to be related to the IDE's viewport.
The reason will be displayed to describe this comment to others. Learn more.
No, it's not related to the view port. We throw this error in general, no matter what the exact issue is, because this problem was almost the only one we had. The underlying issue is probably related to patchwork. Downgrading to ggplot 3.4 resolves this issue (but would not resolve viewport issues). Thus, also since we encourage users to use the latest dev-versions via easystats::install_latest(), it's more important that the easystats packages work for them. I see no problem relying on ggplot 3.4 in see.
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can downgrade the ggplot2 version to 3.4 in see, but how are we going to prevent users from upgrading to ggplot2 3.5? That is out of our hands.
The only way is to set ggplot2 == 3.4.4 in DESCRIPTION, but that would be highly unusual.
I think a lot of users will already have upgraded to 3.5, and we might as well prepare for it and support it in dev-see.
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you downgrading it? All the snapshots were generated with ggplot2 3.5.0 and so this is the minimum version we need to have.
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some issues, possibly related to ggplot 3.5 (not definitely certain yet), and people possibly need to downgrade ggplot to work with see. (easystats/performance#691).
Until it's not clear what's going on, I wanted to make sure that others still can use our packages
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade was made only on GitHub, CRAN version of see doesn't use 3.5.0
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't GitHub using latest ggplot independent from which version we specify on DESCRIPTION? Else, we could add a skip-if-minimum version to snapshot tests, but it's more important to have dev versions work for all users
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, our CI always tries to use the latest version of packages. But I am not sure why you think anything is broken for our users because of the ggplot2 update; we have no concrete evidence to believe that. Currently, users only get some additional warnings when they use see or performance, but there was no breaking change for us coming from ggplot2 update.
The issue Ben is mentioning seems to be related to the IDE's viewport.
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not related to the view port. We throw this error in general, no matter what the exact issue is, because this problem was almost the only one we had. The underlying issue is probably related to patchwork. Downgrading to ggplot 3.4 resolves this issue (but would not resolve viewport issues). Thus, also since we encourage users to use the latest dev-versions via
easystats::install_latest(), it's more important that the easystats packages work for them. I see no problem relying on ggplot 3.4 in see.dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can downgrade the ggplot2 version to 3.4 in see, but how are we going to prevent users from upgrading to ggplot2 3.5? That is out of our hands.
The only way is to set
ggplot2 == 3.4.4in DESCRIPTION, but that would be highly unusual.I think a lot of users will already have upgraded to 3.5, and we might as well prepare for it and support it in dev-see.
dd27c61There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I can follow. see works with any ggplot version >= 3.4.0, so users can upgrade/downgrade to whichever version they want?